Rewrite FilesystemHandler, improve file access and directory listing, support caching headers #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset includes a major rewrite of the
FilesystemHandlerwith improved file access and directory listing and caching support.Filesystem access is pretty fundamental in many applications (think CSS/JavaScript assets), so this should now be ready for production use.
We will likely switch to using non-blocking filesystem APIs with support for external data providers (think S3) in the future, but this should be good enough for now.
Builds on top of #3, #6 and #7, one step closer to #1