Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change auto deployment to use GitHub actions #127

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

SimonFrings
Copy link
Contributor

@SimonFrings SimonFrings commented Nov 22, 2022

Refs reactphp/website#53 and clue/framework-x-website#7.
Builds on top of #125 and #126

@SimonFrings SimonFrings requested a review from clue November 22, 2022 17:27
@SimonFrings SimonFrings force-pushed the auto_deployment branch 4 times, most recently from 74b5b19 to 65ad787 Compare November 24, 2022 15:44
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Changes LGTM, does it make sense to add a badge to show last deployment date for this branch? 👍

@SimonFrings
Copy link
Contributor Author

@clue, I think you're right, I'll add this to my PR 👍

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@SimonFrings
Copy link
Contributor Author

Also added a CI badge :D

@SimonFrings SimonFrings requested a review from clue November 28, 2022 15:29
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Badge URL looks outdated, no?

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the badge URL and use the current format.

@SimonFrings
Copy link
Contributor Author

@clue This should be the right one

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update! :shipit:

@clue clue merged commit b5cb2d6 into clue:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants