Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-12774] remove ledger_id from types based on conserv changes #598

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dwdozier
Copy link
Contributor

DRAFT: still having trouble with:
service_account_null_last_used_by test in user_details
every attempt at getting the correct type in the mock data for
chatgpt_threads results in an error (incorrect type or key must be a string)

Pulling in the new openapi spec from conserv caused a ton of changes :(

DRAFT: still having trouble with:
    service_account_null_last_used_by test in user_details
    every attempt at getting the correct type in the mock data for
chatgpt_threads results in an error (incorrect type or key must be a
string)

Pulling in the new openapi spec from conserv caused a ton of changes :(
@dwdozier dwdozier requested a review from matthewcummings May 31, 2024 01:16
@dwdozier dwdozier self-assigned this May 31, 2024
@dwdozier
Copy link
Contributor Author

The error as it currently sits:

Err(Error("key must be a string", line: 1, column: 616))

This seems to be due to the chatgpt_threads being a HashMap and the deserializer (serde) may not handle it? I am definitely at my limits with this one.

@matthewcummings
Copy link
Member

@dwdozier does your manual override to the generated client code fix this issue?

@matthewcummings
Copy link
Member

Also, can you point me to where you're seeing this error? I don't see it in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants