Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Refs to be hashable using their data #1053

Merged
merged 1 commit into from
May 26, 2018
Merged

Allow Refs to be hashable using their data #1053

merged 1 commit into from
May 26, 2018

Conversation

happyraul
Copy link
Contributor

@happyraul happyraul commented May 25, 2018 •
edited
Loading

With the addition of the __eq__ method (#1048), Refs are no longer hashable. This PR should revert to the previous behavior.

@markpeek markpeek merged commit 4eceaa0 into cloudtools:master May 26, 2018
@markpeek
Copy link
Member

Nice! Thanks!

@phobologic
Copy link
Member

Thanks for fixing this error I introduced, @happyraul !

@michael-k michael-k mentioned this pull request Oct 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@happyraul @markpeek @phobologic