Add ECR policies and make logs policy more flexible #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation of a basic Fargate ECS blueprint.
phobologic
added a commit
that referenced
this pull request
Jun 18, 2018
Only creates a worker service in Fargate, no work done to add load balancers, etc. Relies on #8
Lowercases
approved these changes
Jun 18, 2018
phobologic
added a commit
that referenced
this pull request
Jun 24, 2018
* Add ECR policies and make logs policy more flexible This is in preparation of a basic Fargate ECS blueprint. * Simple Fargate Service + ECS Cluster blueprints Only creates a worker service in Fargate, no work done to add load balancers, etc. Relies on #8 * Cleanup fargate blueprint to working state This also cleans up some confusion in the policies for ecs & cloudwatch. Turns out you can't really use wildcards in cloudwatch stream names. * Key/values in env vars should be strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation of a basic Fargate ECS blueprint.
The aws lambda tests use the cloudwatch log write policy generator, and those tests have not changed, so this should be a no-op as far as existing functionality goes.