Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip empty DDL statements #126

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

asetty
Copy link
Contributor

@asetty asetty commented Dec 19, 2024

WHAT

Check empty DDL statements and skip them when loading

WHY

Behavior was changed in a recent version which did not allow creating an empty database.
PR Migrate to memefish (#121) introduced the change

Fixes Issue #125

Copy link

google-cla bot commented Dec 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aaronbee
Copy link

@asetty signed it

@asetty
Copy link
Contributor Author

asetty commented Jan 2, 2025

@sinmetal @apstndb Could you take a look at this?

Copy link
Contributor

@apstndb apstndb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've no role in this repo, but LGTM.
CC: @apstndb

@sinmetal sinmetal self-requested a review January 16, 2025 07:24
@sinmetal sinmetal merged commit 8249bb7 into cloudspannerecosystem:master Jan 16, 2025
2 checks passed
@sinmetal
Copy link
Collaborator

@asetty Thank you for contribution!

@0daryo
Copy link

0daryo commented Jan 21, 2025

Thank you team for fixing!
#125 has been resolved. Could we request a release that includes this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants