feat: Change option name (#44)

---
cloudquery · Jan 27, 2023 · 0dd709b · 0dd709b
1 parent cd02912
commit 0dd709b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 15 deletions.
diff --git a/client.go b/client.go
@@ -32,7 +32,7 @@ func NewClient(spec *FileSpec) (*Client, error) {
 		opts := []csvFile.Options{
 			csvFile.WithDelimiter([]rune(spec.csvSpec.Delimiter)[0]),
 		}
-		if spec.csvSpec.IncludeHeaders {
+		if !spec.csvSpec.SkipHeader {
 			opts = append(opts, csvFile.WithHeader())
 		}
 

diff --git a/csv/spec.go b/csv/spec.go
@@ -3,8 +3,8 @@ package csv
 import "fmt"
 
 type Spec struct {
-	IncludeHeaders bool   `json:"include_headers,omitempty"`
-	Delimiter      string `json:"delimiter,omitempty"`
+	SkipHeader bool   `json:"skip_header,omitempty"`
+	Delimiter  string `json:"delimiter,omitempty"`
 }
 
 func (s *Spec) SetDefaults() {

diff --git a/spec_test.go b/spec_test.go
@@ -24,25 +24,25 @@ func TestSpecMethods(t *testing.T) {
 			},
 			preDefaultsCSV: &csv.Spec{},
 			postDefaultsCSV: &csv.Spec{
-				IncludeHeaders: false,
-				Delimiter:      ",",
+				SkipHeader: false,
+				Delimiter:  ",",
 			},
 		},
 		{
 			FileSpec: &FileSpec{
 				Format: FormatTypeCSV,
 				FormatSpec: map[string]any{
-					"delimiter":       ",",
-					"include_headers": true,
+					"delimiter":   ",",
+					"skip_header": true,
 				},
 			},
 			preDefaultsCSV: &csv.Spec{
-				IncludeHeaders: true,
-				Delimiter:      ",",
+				SkipHeader: true,
+				Delimiter:  ",",
 			},
 			postDefaultsCSV: &csv.Spec{
-				IncludeHeaders: true,
-				Delimiter:      ",",
+				SkipHeader: true,
+				Delimiter:  ",",
 			},
 		},
 		{
@@ -51,12 +51,12 @@ func TestSpecMethods(t *testing.T) {
 				FormatSpec: map[string]any{},
 			},
 			preDefaultsCSV: &csv.Spec{
-				IncludeHeaders: false,
-				Delimiter:      "",
+				SkipHeader: false,
+				Delimiter:  "",
 			},
 			postDefaultsCSV: &csv.Spec{
-				IncludeHeaders: false,
-				Delimiter:      ",",
+				SkipHeader: false,
+				Delimiter:  ",",
 			},
 		},
 		{