Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform 0.12 support #63

Merged
merged 27 commits into from
Jun 6, 2019
Merged

Terraform 0.12 support #63

merged 27 commits into from
Jun 6, 2019

Conversation

osterman
Copy link
Member

@osterman osterman commented May 31, 2019 •
edited
Loading

what

  • Port (rewrite) module with 0.12 syntax

why

  • Module currently does not work with 0.12
  • Much easier syntax

todo

  • update tests
  • update CI to support 0.12
  • verify identical outputs
  • update README
  • update README examples

@osterman osterman added the wip Work in Progress: Not ready for final review or merge label May 31, 2019
@osterman osterman requested a review from aknysh May 31, 2019 06:36
@osterman osterman marked this pull request as ready for review June 5, 2019 05:48
@osterman osterman removed the wip Work in Progress: Not ready for final review or merge label Jun 5, 2019
Nuru
Nuru requested changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin examples to TF 0.12

osterman and others added 2 commits June 5, 2019 11:20
@osterman @Nuru
Update examples/autoscalinggroup/versions.tf
f642bbc 
Co-Authored-By: Nuru <Nuru@users.noreply.github.com>
@osterman @Nuru
Update examples/complete/versions.tf
4cf6f6d 
Co-Authored-By: Nuru <Nuru@users.noreply.github.com>
aknysh
aknysh reviewed Jun 5, 2019
View reviewed changes
aknysh
aknysh reviewed Jun 5, 2019
View reviewed changes
aknysh
aknysh reviewed Jun 5, 2019
View reviewed changes
aknysh
aknysh reviewed Jun 5, 2019
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
one nitpick

osterman and others added 4 commits June 5, 2019 17:32
@osterman @aknysh
Update main.tf
eea6f23 
Co-Authored-By: Andriy Knysh <aknysh@users.noreply.github.com>
@osterman @aknysh
Update test/src/Makefile
b149b5f 
Co-Authored-By: Andriy Knysh <aknysh@users.noreply.github.com>
@osterman
add test scenario
1b2077b
@osterman
Merge branch '0.12' of github.com:cloudposse/terraform-null-label int…
b463757 
…o 0.12
aknysh
aknysh previously approved these changes Jun 6, 2019
View reviewed changes
@osterman osterman requested a review from aknysh June 6, 2019 01:06
@osterman osterman merged commit e2b880b into master Jun 6, 2019
@osterman osterman deleted the 0.12 branch June 6, 2019 01:27
@osterman osterman mentioned this pull request Jun 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru requested changes

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osterman @boitewitte @Nuru @aknysh