Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tags #43

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Fix tags #43

merged 3 commits into from
Sep 11, 2018

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Sep 11, 2018 •
edited by osterman
Loading

what

  • Fix tags: don't include tags with empty values
  • Fix Travis URL in README

why

  • Many resources (e.g. Elastic Beanstalk) fail if provided with tags with empty values

references

@aknysh aknysh self-assigned this Sep 11, 2018
@aknysh aknysh requested review from osterman and goruha September 11, 2018 17:23
goruha
goruha previously approved these changes Sep 11, 2018
View reviewed changes
@aknysh aknysh requested a review from goruha September 11, 2018 18:37
@aknysh aknysh merged commit 5fea994 into master Sep 11, 2018
@aknysh aknysh deleted the fix-tags branch September 11, 2018 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goruha goruha goruha approved these changes

@osterman osterman Awaiting requested review from osterman

Assignees

@aknysh aknysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Empty Tags
2 participants
@aknysh @goruha