fixes typo/reference in README.md #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: camilo santana <camilo.santana@procore.com>
osterman
reviewed
Aug 23, 2018
| @@ -52,7 +52,7 @@ module "eg_prod_bastion_label" { | |||
| } | |||
| ``` | |||
|
|
|||
| This will create an `id` with the value of `eg-prod-bastion-public`. | |||
| This will create an `id` with the value of `eg_prod_bastion_label`. | |||
There was a problem hiding this comment.
Hrm... so I think what we're trying to say is that the value of eg_prod_bastion_label.id is eg-prod-bastion-public because namespace=eg, stage=prod, name=bastion and attributes=public.
Perhaps there's a better way to say this or explain it?
There was a problem hiding this comment.
i think that's an excellent explanation.
Perhaps,
"this will generate an id with the value of eg-prod-bastion-public based off the key:value pairs above."
or any version thereof. my point is that line would benefit from further elaboration.
thanks for clarifying.
aknysh
reviewed
Aug 24, 2018
|
Addressed in #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README references
eg-prod-bastion-publicresource that doesn't exist yet in the step where it's mentioned. i believeeg-prod-bastion-labelis intended here.Signed-off-by: camilo santana camilo.santana@procore.com