Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore backward compatibility with v0.22.1 and earlier #121

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Restore backward compatibility with v0.22.1 and earlier #121

merged 2 commits into from
Feb 4, 2021

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 4, 2021 •
edited
Loading

what

  • Restore backward compatibility with v0.22.1 and earlier
  • Allow setting of label_key_case and label_value_case by vars, not just by context attributes.

why

  • Allow interoperability of old and new modules
  • Normally, root modules make settings via individual variables, not by setting an entire context block.

Incorporates and closes #120

@Nuru Nuru requested review from aknysh, maximmi and osterman February 4, 2021 07:46
maximmi
maximmi approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@maximmi maximmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@osterman
Copy link
Member

osterman commented Feb 4, 2021

/test all

@Nuru Nuru marked this pull request as ready for review February 4, 2021 08:04
@Nuru Nuru requested a review from a team as a code owner February 4, 2021 08:04
@Nuru
Copy link
Contributor Author

Nuru commented Feb 4, 2021

/test all

@Nuru Nuru merged commit 2de8bb4 into master Feb 4, 2021
@Nuru Nuru deleted the compat branch February 4, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@maximmi maximmi maximmi approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nuru @osterman @maximmi @cloudpossebot