Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all context inputs as normalized outputs #100

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Include all context inputs as normalized outputs #100

merged 3 commits into from
Aug 27, 2020

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Aug 27, 2020

Enhancement to #99

what

  • Include all context inputs as normalized outputs

why

  • Enable a consistent pattern of module.this.context.var to reference the input value with null defaults and module.this.var to reference the normalized value with nulls replaced by actual default values.

references

@Nuru Nuru added the patch A minor, backward compatible change label Aug 27, 2020
@Nuru Nuru requested review from a team as code owners August 27, 2020 19:22
@Nuru Nuru requested review from adamcrews and aknysh and removed request for a team August 27, 2020 19:22
@Nuru
Copy link
Contributor Author

Nuru commented Aug 27, 2020

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Aug 27, 2020

/rebuild-readme

@Nuru
Copy link
Contributor Author

Nuru commented Aug 27, 2020

/test all

outputs.tf Outdated
@@ -60,6 +80,9 @@ output "normalized_context" {

output "context" {
value = local.input
description = "Merged but otherwise unmodified input to this module, to be use as context input to other modules."
description = <<-EOT
Merged but otherwise unmodified input to this module, to be use as context input to other modules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Merged but otherwise unmodified input to this module, to be use as context input to other modules.
Merged but otherwise unmodified input to this module, to be used as context input to other modules.

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nitpick

@Nuru Nuru requested review from aknysh and danjbh August 27, 2020 19:53
@Nuru
Copy link
Contributor Author

Nuru commented Aug 27, 2020

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Aug 27, 2020

/test terratest

@Nuru Nuru merged commit dec8215 into master Aug 27, 2020
@Nuru Nuru deleted the full-output branch August 27, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants