Add bucket_name input. Update s3-log-storage to 1.2.0 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nuru
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what && why
bucket_nameinput. Closes Specify exact bucket name #41. Supersedes and closes feature:Add bucket_name variable #42.s3-log-storageto current 1.2.0. Fixes breakage caused by new AWS S3 defaults. Supersedes and closes chore(deps): update terraform cloudposse/s3-log-storage/aws to v1.1.0 #61.Issues resolved
cloudposse/s3-log-storage/awsto 0.28.2 #55