Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update main.tf #50

Merged
merged 10 commits into from
Oct 21, 2022
Merged

Update main.tf #50

merged 10 commits into from
Oct 21, 2022

Conversation

karinatitov
Copy link
Contributor

have a chance to configure the name of the policy

what

  • With this change i want to have an ability to provide a custom name for the policy

why

  • the resources i'm working with were not created in the same way this module assumes
  • to have a chance to configure the name of the policy

@karinatitov
Update main.tf
9369977 
have a chance to configure the name of the policy
@karinatitov karinatitov requested review from a team as code owners October 19, 2022 20:50
Gowiem
Gowiem reviewed Oct 19, 2022
View reviewed changes
@aknysh
Copy link
Member

aknysh commented Oct 21, 2022

/test all

@aknysh aknysh added the minor New features that do not break anything label Oct 21, 2022
aknysh
aknysh approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @karinatitov

@aknysh aknysh merged commit d03c399 into cloudposse:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem left review comments

@aknysh aknysh aknysh approved these changes

@QuentinBtd QuentinBtd QuentinBtd approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karinatitov @aknysh @Gowiem @QuentinBtd @cloudpossebot