Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update assume actions variable to support multiple actions #29

Merged
merged 2 commits into from
Sep 10, 2021
Merged

update assume actions variable to support multiple actions #29

merged 2 commits into from
Sep 10, 2021

Conversation

mcalhoun
Copy link
Member

@mcalhoun mcalhoun commented Sep 9, 2021 •
edited
Loading

what

  • Rename the assume_role_action variable to assume_role_actions
  • Update the assume_role_action to allow multiple actions
  • Update the default action to include sts:TagSession

why

  • Allow the flexibility of adding multiple actions to the trust policy

NOTE: THIS PR CONTAINS A BACKWARD-INCOMPATIBLE CHANGE

@mcalhoun mcalhoun requested review from a team as code owners September 9, 2021 19:59
@mcalhoun mcalhoun changed the title update assume actions update assume actions variable to support multiple actions Sep 9, 2021
@mcalhoun mcalhoun requested a review from a team as a code owner September 9, 2021 20:00
@mcalhoun mcalhoun requested review from Gowiem and Benbentwo September 9, 2021 20:00
@nitrocode
Copy link
Member

/test all

@mcalhoun mcalhoun merged commit 3fae1bb into master Sep 10, 2021
@mcalhoun mcalhoun deleted the feature/update-assume-role-action branch September 10, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@Benbentwo Benbentwo Awaiting requested review from Benbentwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcalhoun @nitrocode @cloudpossebot