Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include new AMI types AL2023_x86_64_(NVIDIA|NEURON) #202

Merged
merged 3 commits into from
Feb 9, 2025

Conversation

m-wynn
Copy link
Contributor

@m-wynn m-wynn commented Jan 13, 2025

what

  • Amazon has some new AMI types
    • AL2023_x86_64_NEURON
    • AL2023_x86_64_NVIDIA
  • These follow the same SSM parameters
    • /aws/service/eks/optimized-ami/1.31/amazon-linux-2023/x86_64/neuron/amazon-eks-node-al2023-x86_64-neuron-1.31-v20250103/image_id
    • /aws/service/eks/optimized-ami/1.31/amazon-linux-2023/x86_64/nvidia/amazon-eks-node-al2023-x86_64-nvidia-1.31-v20250103/image_id
    • /aws/service/eks/optimized-ami/1.31/amazon-linux-2023/x86_64/neuron/recommended/image_id
    • /aws/service/eks/optimized-ami/1.31/amazon-linux-2023/x86_64/nvidia/recommended/image_id

why

We want to be able to deploy all types of AMIs into our cluster for GPU and ML purposes. These are the AL2023 equivalents of AL2_x86_64_GPU

references

https://github.com/awslabs/amazon-eks-ami/releases
https://aws.amazon.com/blogs/containers/amazon-eks-optimized-amazon-linux-2023-accelerated-amis-now-available/

@m-wynn m-wynn requested review from a team as code owners January 13, 2025 20:02
@m-wynn m-wynn requested review from Gowiem and gberenice January 13, 2025 20:02
@mergify mergify bot added the triage Needs triage label Jan 13, 2025
@Gowiem
Copy link
Member

Gowiem commented Jan 13, 2025

/terratest

@Gowiem
Copy link
Member

Gowiem commented Jan 13, 2025

@m-wynn Unfortunately, we will need to run some automation to pass our tests. Mind doing the following locally, adding + committing the result, and pushing to your branch?

make init
make readme

Thanks!

@m-wynn
Copy link
Contributor Author

m-wynn commented Jan 13, 2025

I did a little more looking into this and this may need some upstream work first: https://github.com/aws/aws-sdk-go/blob/main/models/apis/eks/2017-11-01/api-2.json#L908

Newer versions of terraform-provider-aws use a different library

@m-wynn m-wynn closed this Jan 13, 2025
@mergify mergify bot removed the triage Needs triage label Jan 13, 2025
@m-wynn
Copy link
Contributor Author

m-wynn commented Jan 13, 2025

actually my bad, I just had a really old version of terraform-provider-aws

@m-wynn m-wynn reopened this Jan 13, 2025
@mergify mergify bot added the triage Needs triage label Jan 13, 2025
@Gowiem Gowiem added enhancement New feature or request minor New features that do not break anything feature New functionality and removed triage Needs triage labels Jan 13, 2025
@Gowiem
Copy link
Member

Gowiem commented Jan 13, 2025

/terratest

@Gowiem Gowiem enabled auto-merge (squash) February 8, 2025 22:47
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Gowiem
Copy link
Member

Gowiem commented Feb 8, 2025

/terratest

@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label Feb 9, 2025
@Gowiem Gowiem merged commit 416a689 into cloudposse:main Feb 9, 2025
26 checks passed
Copy link

github-actions bot commented Feb 9, 2025

These changes were released in v3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New functionality minor New features that do not break anything no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants