-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force_update_version
and replace_node_group_on_version_update
variables
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/terratest |
/terratest |
/terratest |
/terratest |
force_update_version
and include_kubernetes_version_in_keepers
variablesforce_update_version
and force_node_group_replacement
variables
kcarter-bread
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
force_update_version
and force_node_group_replacement
variablesforce_update_version
and replace_node_group_on_version_upodate
variables
force_update_version
and replace_node_group_on_version_upodate
variablesforce_update_version
and replace_node_group_on_version_update
variables
/terratest |
Nuru
requested changes
Sep 26, 2023
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
/terratest |
Nuru
approved these changes
Sep 26, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
force_update_version
andreplace_node_group_on_version_update
variableswhy
force_update_version
allows forcing version update if existing pods are unable to be drained due to a pod disruption budget issue. Default isfalse
for backwards compatibilityIf the variable
replace_node_group_on_version_update
is set totrue
and the EKS cluster is updated to a new Kubernetes version, the Node Groups will be replaced instead of updated in-place. This is useful when updating very old EKS clusters to a new Kubernetes version where some old releases prevent nodes from being drained (due to PodDisruptionBudget or taint/toleration issues), but replacing the Node Groups works without forcing the pods to leave the old nodes by using theforce_update_version
variable. This is related, for example, toistio
. Default isfalse
for backwards compatibilityreferences