Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow overriding the dynamodb table name #126

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: allow overriding the dynamodb table name #126

merged 1 commit into from
Apr 10, 2024

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Apr 10, 2024 •
edited
Loading

what

  • allow overriding the dynamodb table name

why

  • This will make it possible to import older dynamodb tables without having to null portions of the context
  • Matches s3-bucket module's bucket_name. See below.

references

@nitrocode nitrocode requested review from a team as code owners April 10, 2024 14:38
@mergify mergify bot added the triage Needs triage label Apr 10, 2024
@nitrocode
feat: allow overriding the dynamodb table name
34980bf 
Signed-off-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@mergify mergify bot removed the triage Needs triage label Apr 10, 2024
jamengual
jamengual reviewed Apr 10, 2024
View reviewed changes
@nitrocode
Copy link
Member Author

/terratest

@nitrocode nitrocode enabled auto-merge (squash) April 10, 2024 21:52
@nitrocode nitrocode merged commit 97c8a7a into main Apr 10, 2024
19 checks passed
@nitrocode nitrocode deleted the table-name branch April 10, 2024 21:54
@nitrocode nitrocode mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @jamengual