feat: adding the option to disable ttl once it was enable before

[alfredo-gil]

what

The change aims to be able to disable the TTL once a dynamodb table was enabled before.

why

• With the current dynamic block on the TTL option inside the aws_dynamodb_table resource if you change the var.ttl_enabled = false there are no changes on the infrastructure and the TTL is not disabled:
  No changes. Your infrastructure matches the configuration.
• With this change you can disable the TTL on a dynamodb table that had it enabled before following this process:

• Change the var.ttl_enabled = false Do the plan and apply
• Change later the var.ttl_attribute="" or leave it empty to consolidate the state. If you don't do this second change your plan is going to say something like this and if you try to apply you will have an error...

 ~ resource "aws_dynamodb_table" "default" {
        id                          = "test"
        name                        = "test"
        tags                        = {
            ...
        }
        # (9 unchanged attributes hidden)

      ~ ttl {
          + attribute_name = "ttl"
            # (1 unchanged attribute hidden)
        }

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions in workspace "test"?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

module.dynamodb["test"].module.dynamodb_table.aws_dynamodb_table.default[0]: Modifying... [id=test]
╷
│ Error: updating Amazon DynamoDB Table (test): updating Time To Live: ValidationException: TimeToLive is already disabled
│ 	status code: 400, request id: XXXXXXXXXXXXXXXXXXXXXX
│
│   with module.dynamodb["test"].module.dynamodb_table.aws_dynamodb_table.default[0],
│   on .terraform/modules/dynamodb.dynamodb_table/main.tf line 46, in resource "aws_dynamodb_table" "default":
│   46: resource "aws_dynamodb_table" "default" {
│

references

• This is the origin of the issue aws_dynamodb_table - with ttl disabled, can't "terraform apply" twice hashicorp/terraform-provider-aws#10304

[alfredo-gil]

Hi @joe-niland @Gowiem, this PR is open for some months ago, Do you have any comments?
thanks in advance

[Gowiem]

/terratest

[alfredo-gil]

Hi @joe-niland @Gowiem, any additional requirements to merge this PR?
Many thanks!

[hans-d]

@alfredo-gil can you update the readme (see the failing check)

[joe-niland]

@alfredo-gil and also please update your branch from master

[mergify]

Thanks @alfredo-gil for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.