Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate random password when master_password is empty #42

Merged
merged 6 commits into from
Apr 2, 2022
Merged

Generate random password when master_password is empty #42

merged 6 commits into from
Apr 2, 2022

Conversation

dkossako
Copy link
Contributor

what

  • If master_password is not provided or empty random value will be used

why

  • AWS API requires to provide password
  • Secrets should not be kept in repository

@dkossako dkossako requested review from a team as code owners March 28, 2022 21:15
bridgecrew[bot]
bridgecrew bot reviewed Mar 28, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Mar 28, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Mar 28, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to ba9ebaa - Auto Format - 2 errors were fixed.

Change details

Error ID Change Path Resource
BC_AWS_GENERAL_102 Fixed /main.tf module.documentdb_cluster.aws_docdb_cluster.default
BC_AWS_LOGGING_19 Fixed /main.tf module.documentdb_cluster.aws_docdb_cluster.default

@dkossako
Copy link
Contributor Author

can someone let me know what's wrong with bridgecrew analysis? I don't have access there

Gowiem
Gowiem reviewed Mar 29, 2022
View reviewed changes
docs/terraform.md Outdated
@@ -12,6 +12,7 @@
| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 2.0 |
| <a name="provider_random"></a> [random](#provider\_random) | n/a |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkossako can you please add the random provider explicitly to versions.tf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Gowiem
Copy link
Member

Gowiem commented Mar 29, 2022

/test all

@Gowiem
Copy link
Member

Gowiem commented Mar 29, 2022

@dkossako your PR looks good -- You can ignore the BC alerts since they don't seem to be related to your changes.

Please address the request I made in regards to adding the provider explicitly and I'll review. 👍

Daniel Kossakowski and others added 2 commits March 30, 2022 14:35
bridgecrew[bot]
bridgecrew bot reviewed Mar 30, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Mar 30, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Mar 30, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to f919776 - Auto Format - 2 errors were fixed.

Change details

Error ID Change Path Resource
BC_AWS_GENERAL_102 Fixed /main.tf module.documentdb_cluster.aws_docdb_cluster.default
BC_AWS_LOGGING_19 Fixed /main.tf module.documentdb_cluster.aws_docdb_cluster.default

@Gowiem
Copy link
Member

Gowiem commented Mar 30, 2022

/test all

Gowiem
Gowiem previously requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 other requests @dkossako -- Those will be my last. Thanks!

main.tf Outdated Show resolved Hide resolved
versions.tf Outdated Show resolved Hide resolved
@mergify mergify bot dismissed Gowiem’s stale review March 31, 2022 06:54

This Pull Request has been updated, so we're dismissing all reviews.

bridgecrew[bot]
bridgecrew bot reviewed Mar 31, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Mar 31, 2022
View reviewed changes
main.tf Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Mar 31, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to e53f791 - Auto Format - 2 errors were fixed.

Change details

Error ID Change Path Resource
BC_AWS_GENERAL_102 Fixed /main.tf module.documentdb_cluster.aws_docdb_cluster.default
BC_AWS_LOGGING_19 Fixed /main.tf module.documentdb_cluster.aws_docdb_cluster.default

@Gowiem
Copy link
Member

Gowiem commented Mar 31, 2022

/test all

@Gowiem Gowiem merged commit dbae02d into cloudposse:master Apr 2, 2022
@Gowiem
Copy link
Member

Gowiem commented Apr 2, 2022

@dkossako Thanks for the contribution! Released as https://github.com/cloudposse/terraform-aws-documentdb-cluster/releases/tag/0.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew[bot] left review comments

@Gowiem Gowiem Gowiem approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland was automatically assigned from cloudposse/contributors

@dylanbannon dylanbannon Awaiting requested review from dylanbannon dylanbannon was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkossako @Gowiem @cloudpossebot