Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new attributes #14

Merged
merged 5 commits into from
Oct 23, 2020
Merged

add new attributes #14

merged 5 commits into from
Oct 23, 2020

Conversation

sergirf
Copy link
Contributor

@sergirf sergirf commented Oct 21, 2020

what

  • add option to change port for the cluster, the variable was defined but not used on the cluster resource so the SG was using it but not the cluster.
  • add two attributes important to be sure no unexpected downtime without being planed: preferred_maintenance_window and auto_minor_version_upgrade

why

  • we want to have the cluster up to date on the last minor release
  • we want to be able to change the default port

references

  • No issue or bug fix, just some additions

@sergirf sergirf requested a review from a team as a code owner October 21, 2020 21:31
@SweetOps
Copy link

/rebuild-readme

@SweetOps
Copy link

/test all

@SweetOps
Copy link

/terraform-fmt

@SweetOps
Copy link

/test all

1 similar comment
@SweetOps
Copy link

/test all

@SweetOps SweetOps merged commit bb3928b into cloudposse:master Oct 23, 2020
@sergirf
Copy link
Contributor Author

sergirf commented Oct 25, 2020

thanks for the quick merge, really appreciate it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SweetOps SweetOps SweetOps approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergirf @SweetOps @actions-bot