Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement deletion_protection option #30

Closed
vkrasheninnikov opened this issue Feb 11, 2021 · 0 comments · Fixed by #32
Closed

Implement deletion_protection option #30

vkrasheninnikov opened this issue Feb 11, 2021 · 0 comments · Fixed by #32

Comments

@vkrasheninnikov
Copy link

An official aws_docdb_cluster resource supports deletion_protection option, while this module not. It would be good to add this attribute.

Expected Behavior

The module accepts deletion_protection boolean parameter and toggles the option accordingly.

Use Case

It would be good to have an additional guardrail for a production environment.
krsh-off added a commit to krsh-off/terraform-aws-documentdb-cluster that referenced this issue Feb 11, 2021
@krsh-off
Issue cloudposse#30: Add deletion_protection parameter
bab76eb
@vkrasheninnikov vkrasheninnikov mentioned this issue Feb 11, 2021
Closed
@krsh-off krsh-off mentioned this issue Feb 11, 2021
Merged
@SweetOps SweetOps linked a pull request Feb 13, 2021 that will close this issue
Add deletion_protection parameter #32
Merged
SweetOps pushed a commit that referenced this issue Feb 13, 2021
@krsh-off @cloudpossebot @actions-bot
Add deletion_protection parameter (#32)
5c900d9 
* Issue #30: Add deletion_protection parameter

* Auto Format

* Updated README.md

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deletion_protection parameter krsh-off/terraform-aws-documentdb-cluster
1 participant
@vkrasheninnikov