Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dd lambda to allow specifying region for configuration component #1163

Merged
merged 4 commits into from
Nov 6, 2024
Merged

update dd lambda to allow specifying region for configuration component #1163

merged 4 commits into from
Nov 6, 2024

Conversation

Benbentwo
Copy link
Member

@Benbentwo Benbentwo commented Oct 16, 2024 •
edited
Loading

what

  • allows datadog-lambda forwarder to specify a global region override for environment

why

  • since we cannot do dynamic providers we should make datadog_configuration be regional

Example Stack configuration

import:
  - orgs/acme/plat/dev/_defaults
  - mixins/region/us-east-1
  - catalog/datadog/configuration
  - catalog/datadog/lambda-forwarder

components:
  terraform:
    datadog-configuration:
      vars:
        datadog_secrets_store_type: SSM
        datadog_secrets_source_store_account_stage: auto
        datadog_secrets_source_store_account_region: "us-west-2"

    datadog-lambda-forwarder:
      vars:
        datadog_configuration_environment: "use1"

@Benbentwo Benbentwo requested review from a team as code owners October 16, 2024 22:13
@goruha goruha merged commit 1730b0b into main Nov 6, 2024
4 checks passed
@goruha goruha deleted the escape-hatch-dd-region branch November 6, 2024 23:17
goruha added a commit to cloudposse-terraform-components/aws-datadog-credentials that referenced this pull request Nov 27, 2024
@Benbentwo @goruha
update dd lambda to allow specifying region for configuration compone…
9856abe 
…nt (cloudposse/terraform-aws-components#1163)

Co-authored-by: Igor Rodionov <goruha@gmail.com>
goruha added a commit to cloudposse-terraform-components/aws-datadog-lambda-forwarder that referenced this pull request Nov 27, 2024
@Benbentwo @goruha
update dd lambda to allow specifying region for configuration compone…
11c95d5 
…nt (cloudposse/terraform-aws-components#1163)

Co-authored-by: Igor Rodionov <goruha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goruha goruha goruha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Benbentwo @goruha