Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Smoke Tests to Check for Stale Atmos Binary #1063

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Update Smoke Tests to Check for Stale Atmos Binary #1063

merged 2 commits into from
Feb 17, 2025

Conversation

osterman
Copy link
Member

@osterman osterman commented Feb 14, 2025 •
edited
Loading

what

  • Error if the atmos binary is older than the .go files
  • Error if the atmos binary discovered from the PATH is not within the repository
  • Introduce charmbracelet logger

why

  • Smoketests run the atmos binary from the build
  • We didn't check that the binary was stale, so an out of date binary could be used
  • We didn't check that atmos from the build was in the PATH
  • Logging wasn't easy because the test model isn't accessible everywhere, so using the charmbracelet logger is easy
  • Developers frequently missed pertient log messages; color logs make it easier to see what's going on

screenshots

General info

image

Wrong atmos binary

image

Stale atmos binary

image

@osterman osterman requested a review from a team as a code owner February 14, 2025 03:49
@mergify mergify bot added the triage Needs triage label Feb 14, 2025
@osterman osterman added the no-release Do not create a new release (wait for additional code changes) label Feb 17, 2025
@osterman osterman merged commit 034e806 into main Feb 17, 2025
45 checks passed
@osterman osterman deleted the check-atmos branch February 17, 2025 00:37
@mergify mergify bot removed the triage Needs triage label Feb 17, 2025
@github-actions GitHub Actions
Copy link

These changes were released in v1.163.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@osterman