Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Test Timeouts and Clean Working & Home Directories #1051

Merged
merged 6 commits into from
Feb 12, 2025
Merged

Add Test Timeouts and Clean Working & Home Directories #1051

merged 6 commits into from
Feb 12, 2025

Conversation

osterman
Copy link
Member

@osterman osterman commented Feb 11, 2025 •
edited
Loading

what

  • Add a new timeout configuration to abort long running tests
  • Disable version checks on tests that are not testing that functionality
  • Change home directory to empty temp directory

why

  • It's hard to identify sometimes which test is hung in CI; adding a timer makes it easier to track down
  • Atmos and terraform orphan files (e.g. cache files) which means test behavior can change between runs
  • Home directory configuration can affect test outcomes

@mergify mergify bot added the triage Needs triage label Feb 11, 2025
@osterman osterman added the no-release Do not create a new release (wait for additional code changes) label Feb 11, 2025
@osterman osterman changed the title test timeouts Add Test Timeouts and Clean Working Directories Feb 11, 2025
@osterman osterman marked this pull request as ready for review February 11, 2025 23:12
@osterman osterman requested review from a team as code owners February 11, 2025 23:12
@osterman osterman changed the title Add Test Timeouts and Clean Working Directories Add Test Timeouts and Clean Working & Home Directories Feb 12, 2025
@osterman osterman removed the triage Needs triage label Feb 12, 2025
@osterman osterman merged commit 3dda727 into main Feb 12, 2025
44 checks passed
@osterman osterman deleted the test-timeouts branch February 12, 2025 15:44
@github-actions GitHub Actions
Copy link

These changes were released in v1.161.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@osterman