Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve images from nodepool template #15

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

jwcesign
Copy link
Contributor

@jwcesign jwcesign commented Mar 9, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

testing result:

spec:
  imageSelectorTerms:
  - alias: Ubuntu
status:
  conditions:
  - lastTransitionTime: "2025-03-02T09:07:00Z"
    message: ""
    observedGeneration: 2
    reason: ImagesReady
    status: "True"
    type: ImagesReady
  - lastTransitionTime: "2025-03-02T09:07:00Z"
    message: ""
    observedGeneration: 2
    reason: Ready
    status: "True"
    type: Ready
  images:
  - requirements:
    - key: kubernetes.io/arch
      operator: In
      values:
      - arm64
    - key: karpenter.k8s.gcp/instance-gpu-count
      operator: DoesNotExist
    sourceImage: projects/ubuntu-os-gke-cloud/global/images/ubuntu-gke-2204-1-31-arm64-20250128
  - requirements:
    - key: kubernetes.io/arch
      operator: In
      values:
      - amd64
    sourceImage: projects/ubuntu-os-gke-cloud/global/images/ubuntu-gke-2204-1-31-v20250128

karpenter will create two gke nodepool template and resolve the images from it's derived instance template

Does this PR introduce a user-facing change?


Signed-off-by: jwcesign <jwcesign@cloudpilot.ai>
@jwcesign jwcesign merged commit ef1e1e7 into cloudpilot-ai:main Mar 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant