-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where to put favicon, other root assets? #33
Comments
Perhaps we should include these by default:
|
This relates to #40 |
No one seems to feel strongly about where this lives. If this gets too big, this doesn't necessarily need to make it into 1.0 |
Okay, I think I finally have an opinion on this. I wanted to share my "plan of attack" with @erikjung and @mrgerardorodriguez first before proceeding. Directory StructureI'm going to set aside for a moment the question of "is But in a perfect world, where would the static assets live? For me, that's easy: I don't think it should live higher up in the structure than Gulp taskAs noted in cloudfour/core-gulp-tasks#26, the "assets" task is kind of a mess. To recap:
I would like to replace that task with a task called If we ever want an image-processing task again, we should give it a name like Plan of AttackIf all of that sounds good, the next steps would be to...
But first...Does all of that make sense? |
Works for me! 👍 |
Can we just call the task Otherwise, 👍 |
Sure, totally fine by me. |
The simplest method of including
favicon.ico
is in the root directory, which also avoids any 404 requests in the browser. Many static generators have anhtdocs
orstatic
directory for assets that should be copied over verbatim. It would be nice to not have to specify<link>
elements for this info.The text was updated successfully, but these errors were encountered: