Disable renovating node version #727
Conversation
| { | ||
| "packageNames": ["node"], | ||
| "enabled": false | ||
| } |
There was a problem hiding this comment.
So this is saying:
- Find any package named "node"
- Apply the following special rules to it:
- The only special rule is to entirely disable renovate for it.
Is that right?
There was a problem hiding this comment.
Yes that is my understanding
There was a problem hiding this comment.
@calebeby this code looks good to me.
Is there any way to test this without merging it? If not it might be good to get another pair of eyes on it. I know @spaceninja has some renovate experience.
|
No we don't have a way to test this until we merge it. Here was my last shot at this: #689 narrator: it did not work |
|
Cool, well the code looks good to me based on the linked issue and Renovate docs ¯\_(ツ)_/¯ I assume after we merge we just wanna keep an eye on Renovate to make sure it keeps acting correctly? |
|
Yeah, should I merge or should I wait for @spaceninja to review? |
|
After this is merged, I am expecting/hoping that this will auto-close: #690 |
|
Your call. I'm tempted to wait for @spaceninja 's review, but worst case this breaks renovate and not our actual codebase, so if you'd prefer to merge now that's fine with me |
Tries to disable PR's like this: #690
I think this is the config we want: renovatebot/config-help#81 (comment)