Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More waiting time for webdriver #3246

Closed
wants to merge 1 commit into from
Closed

More waiting time for webdriver #3246

wants to merge 1 commit into from

Conversation

strehle
Copy link
Member

@strehle strehle commented Jan 18, 2025

@strehle strehle requested a review from duanemay January 18, 2025 10:50
@duanemay
Copy link
Member

The implicit wait increases test script execution time, if we use explicit waits or convert to using asserts on the selenium tests to awaitility then we can use the await().atMost(Duration.ofSeconds(30)).untilAsserted(() -> ...) which will check the condition repeatedly until it passes then proceed.

You can see the these Pages objects have been moved to awaitility, lower in the file. We can definitely increase that timeout and should only affect the test execution times where it fails to load the element.

@strehle
Copy link
Member Author

strehle commented Jan 20, 2025

The implicit wait increases test script execution time, if we use explicit waits or convert to using asserts on the selenium tests to awaitility then we can use the await().atMost(Duration.ofSeconds(30)).untilAsserted(() -> ...) which will check the condition repeatedly until it passes then proceed.

You can see the these Pages objects have been moved to awaitility, lower in the file. We can definitely increase that timeout and should only affect the test execution times where it fails to load the element.

ok, so we can also revert this..

I have issues with latest chrom... 132 see new PRs
https://github.com/cloudfoundry/uaa-ci/pull/25
#3248

@strehle strehle closed this Jan 20, 2025
@strehle strehle deleted the pageWebdriver branch January 20, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants