Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retry for unit tests #3244

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

duanemay
Copy link
Member

From #3229
We want unit tests to be as robust as possible.

Experiment: remove retries, and fix tests.
If it fails too often and is blocking, we can re-introduce retries at the test level with the junit-pioneer @RetryingTest annotation.

Signed-off-by: Duane May <duane.may@broadcom.com>
@duanemay duanemay linked an issue Jan 17, 2025 that may be closed by this pull request
@duanemay
Copy link
Member Author

We did see one failure on container-test-job postgresql-16

DeprecatedUaaTokenServicesTests > createAccessTokenRefreshGrantSomeScopesAutoApprovedDowngradedRequest(TestTokenEnhancer) > 1: old behavior FAILED
    java.lang.AssertionError: 
    Expecting actual:
      eyJqa3UiOiJodHRwczovL3VhYS51cmwvdG9rZW5fa2V5cyIsImtpZCI6InRlc3RLZXkiLCJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiIxMjM0NSIsInVzZXJfbmFtZSI6Impkc2EiLCJvcmlnaW4iOiJ1YWEiLCJpc3MiOiJodHRwOi8vbG9jYWxob3N0OjgwODAvdWFhL29hdXRoL3Rva2VuIiwicmV2b2NhYmxlIjp0cnVlLCJjbGllbnRfaWQiOiJjbGllbnQiLCJhdWQiOlsic2NpbSIsImNsaWVudHMiXSwiemlkIjoidWFhIiwiZ3JhbnRfdHlwZSI6ImF1dGhvcml6YXRpb25fY29kZSIsInVzZXJfaWQiOiIxMjM0NSIsImF6cCI6ImNsaWVudCIsInNjb3BlIjpbInJlYWQiXSwiZXhwIjoxNzM3MTk2ODUxLCJpYXQiOjE3MzcxNTM2NTIsImp0aSI6ImY1ZTMzMTk4YWM1MTQ3YmJiNzVlZWIzZDA4ZDZhMmJiIiwiZW1haWwiOiJqZHNhQHZtd2FyZS5jb20iLCJyZXZfc2lnIjoiMzMxNGRjOTgiLCJjaWQiOiJjbGllbnQifQ.RzJfLVva7NznhuS0ORic9Nv0hXvmQyAWibhKFXZms4s
    to be should be valid for <is <43200>>
        at org.cloudfoundry.identity.uaa.oauth.DeprecatedUaaTokenServicesTests.createAccessTokenRefreshGrantSomeScopesAutoApprovedDowngradedRequest(DeprecatedUaaTokenServicesTests.java:982)

@strehle
Copy link
Member

strehle commented Jan 18, 2025

I re-run the unit tests 2 additional times... no failure, so good enough to merge...

The bigger problem is in integration test and timeout with simple saml... the 5 sec. timeout is too small

@strehle strehle merged commit 2f178a3 into develop Jan 18, 2025
22 checks passed
@strehle strehle deleted the 3229-remove-retry-for-unit-tests branch January 18, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Remove retry for unit tests
2 participants