Solve issue 3226 #3234
Merged
Solve issue 3226 #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue seems to be that when UAA is running on a standard port :80 or :443 and that port is included in the metadata. The destination within the SAML response includes the port, but the location from the relying party registration does not. Therefore the comparison does not match and authentication fails. |
|
Agreed that the default port stripping is probably at the root of this. The purpose behind this change is to expose both of the elements being compared in the conditional so that it is clearer why this particular error is returned by UAA. Having only half of the information in the error message makes it impossible to understand the root cause when this error occurs. |
duanemay
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.