Fix file/dir creation permissions

cloudfoundry · Sep 13, 2024 · a085a2b · a085a2b
1 parent 6c72122
commit a085a2b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/code.cloudfoundry.org/iptables-logger/cmd/iptables-logger/main.go b/src/code.cloudfoundry.org/iptables-logger/cmd/iptables-logger/main.go
@@ -98,7 +98,7 @@ func main() {
 		HostGuid:      conf.HostGuid,
 	}
 	iptablesLogger := lager.NewLogger(fmt.Sprintf("%s.iptables", logPrefix))
-	outputLogFile, err := os.OpenFile(conf.OutputLogFile, os.O_RDWR|os.O_CREATE|os.O_APPEND, 0666)
+	outputLogFile, err := os.OpenFile(conf.OutputLogFile, os.O_RDWR|os.O_CREATE|os.O_APPEND, 0644)
 	if err != nil {
 		logger.Fatal("open-output-log-file", err)
 	}

diff --git a/src/code.cloudfoundry.org/iptables-logger/rotatablesink/rotatewatcher.go b/src/code.cloudfoundry.org/iptables-logger/rotatablesink/rotatewatcher.go
@@ -117,7 +117,7 @@ func (dfwf DefaultFileWriterFunc) NewWriter(fileName string) (io.Writer, error)
 }
 
 func DefaultFileWriter(fileName string) (io.Writer, error) {
-	return os.OpenFile(fileName, os.O_RDWR|os.O_CREATE|os.O_APPEND, 0666)
+	return os.OpenFile(fileName, os.O_RDWR|os.O_CREATE|os.O_APPEND, 0644)
 }
 
 //go:generate counterfeiter -o ../fakes/destinationfileinfo.go --fake-name DestinationFileInfo . DestinationFileInfo

diff --git a/src/code.cloudfoundry.org/lib/datastore/datastore.go b/src/code.cloudfoundry.org/lib/datastore/datastore.go
@@ -253,7 +253,7 @@ func (c *Store) updateVersion() error {
 	if err != nil {
 		return err
 	}
-	err = os.WriteFile(c.VersionFilePath, []byte(strconv.Itoa(version+1)), os.ModePerm)
+	err = os.WriteFile(c.VersionFilePath, []byte(strconv.Itoa(version+1)), 0600)
 	if err != nil {
 		// not tested
 		return fmt.Errorf("write version file: %s", err)