Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace firehose_exporter, move to attic legacy job and dependencies #461

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

psycofdj
Copy link
Contributor

@psycofdj psycofdj commented Apr 25, 2023

This PR supersedes #414 in bumping firehose_exporter to its new major release v7.0.0.

This major release has a non-backward compatible impact on generated metrics and, therefore, on associated jobs cloudfoundry_dashboards and cloudfoundry_alerts.

In order to allow users to stick to legacy implementation and dashboards, previous jobs and packages has been kept and renamed with -attic suffix:

  • packages/firehose_exporter-attic
  • jobs/firehose_exporter-attic
  • jobs/cloudfoundry_dashboards-attic
  • jobs/cloudfoundry_alerts-attic

These jobs and packages won't benefit from further maintenance.

Additionally, new ops-files are provided to easily switch back to legacy implementation:

  • manifests/operators/deprecated/monitor-cf-attic.yml, to use in addition of manifests/operators/monitor-cf.yml
  • manifests/operators/deprecated/enable-cf-loggregator-v2.yml which replaces deleted manifests/operators/enable-cf-loggregator-v2.yml
  • manifests/operators/deprecated/cf/add-prometheus-uaa-clients-attic.yml to use in addition of manifests/operators/cf/add-prometheus-uaa-clients.yml in cloud foundry deployment

Finally, the mess between "v2" and "original" dashboards in cloudfoundry_dashboards has been cleaned up:

  • v2 dashboards now replace the original ones
  • they have been renamed to match original names
  • v2 tags has been removed and associated dashboard list dropdown has been removed.

Using the manifests/operators/deprecated/monitor-cf-attic.yml ops-file will also revert this change.

Note: new firehose blob firehose_exporter/firehose_exporter_7.0.0.linux-amd64.tar.gz has already been uploaded to AWS S3

@benjaminguttmann-avtq
Copy link
Contributor

I think the README.md is missing some adjustments for the new firehose, right? Can you please check that https://github.com/bosh-prometheus/prometheus-boshrelease#monitoring-cloud-foundry

@psycofdj
Copy link
Contributor Author

I think the README.md is missing some adjustments for the new firehose, right? Can you please check that https://github.com/bosh-prometheus/prometheus-boshrelease#monitoring-cloud-foundry

sure, you are right

@psycofdj
Copy link
Contributor Author

psycofdj commented Apr 26, 2023

here you go @benjaminguttmann-avtq, see d8ad880

@psycofdj psycofdj force-pushed the new-firehose-exporter branch from 6e75789 to d8ad880 Compare April 26, 2023 09:17
@benjaminguttmann-avtq
Copy link
Contributor

I have another question: https://github.com/bosh-prometheus/prometheus-boshrelease/blob/6e757899bdf36fd53eb9d16917299d52e7656656/manifests/operators/monitor-cf.yml#L67

what happens if you use that exactly like it is in there? Will that cause issues because certificates do not match the ones from loggregrator?

@psycofdj
Copy link
Contributor Author

psycofdj commented Apr 26, 2023

Prometheus-boshrelease users have to specify a value for this variable. I will add details in the README.md in ad additional commit .

The idea here is to generate a authentication certificate. In order to be accepted by reverse_log_proxy (lpr), this certificate has to be generated from the loggregator CA.
This CA is already in credhub but belongs to cloud foundry deployment (generated by cf-deployment). To access it from another deployment, we must specify its full path, something like /bosh-mydirector/cf/loggregator_ca.

@psycofdj
Copy link
Contributor Author

here you are: 2d354e5

@psycofdj psycofdj merged commit 43d2b2d into master Apr 27, 2023
@psycofdj psycofdj deleted the new-firehose-exporter branch May 2, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants