Bump github.com/gorilla/websocket from 1.5.0 to 1.5.1 in /src #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.5.0 to 1.5.1. - [Release notes](https://github.com/gorilla/websocket/releases) - [Commits](gorilla/websocket@v1.5.0...v1.5.1) --- updated-dependencies: - dependency-name: github.com/gorilla/websocket dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
72acd37 to
3db0598
Compare
The tests were failing consistently with the new gorilla/websocket package. The nature of the failures indicated that the tests were at fault rather than new functionality from the package. This commit refactors the tests to use a websocket client in order to connect to the test server in standard, supported way. Additionally, it updates many of the tests that weren't actually testing what their descriptions purported they were testing. One test for "old-style keep-alives" was completely removed. The test wasn't really testing for it, and we couldn't find any evidence that it is a real thing that we should support. wip
This test was failing with the new gorilla/websocket.
6eea57c to
714af33
Compare
rroberts2222
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.