Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Modernize as a cf CLI plugin #66

Closed
wants to merge 12 commits into from
Closed

Feat: Modernize as a cf CLI plugin #66

wants to merge 12 commits into from

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Feb 4, 2022 •
edited
Loading

Description

Update and reorganize this repo around the idea of being the log-cache cf CLI plugin, not a standalone CLI as well.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@ctlong ctlong force-pushed the feat/no-standalone-cli branch from 8ee7b2d to 4e965fa Compare February 4, 2022 07:49
@ctlong
Copy link
Member Author

ctlong commented Feb 7, 2022

Cherrypicked the documentation half of this into a separate PR #67

@ctlong ctlong force-pushed the feat/no-standalone-cli branch from 5f4f95f to ce7e4d4 Compare February 25, 2022 21:53
@ctlong
Change pkg/command/cf path to internal/command path
d4498ce 
We don't expect any of these commands to be used externally to this cf
CLI plugin, so there's no point in exporting them. Moving them behind
internal makes them only available to our main package.
@ctlong ctlong force-pushed the feat/no-standalone-cli branch from ce7e4d4 to d4498ce Compare February 25, 2022 22:25
@ctlong
Simplify Run() and remove unused funcs from main
27036b8 
Don't need to check for arg size, if there wasn't at least one arg then
it wouldn't be redirected to our plugin. By using a switch we can also
ignore the case where the plugin is being uninstalled.
@ctlong ctlong changed the title Feat: No Longer a Standalone CLI Feat: Purely a cf CLI plugin Feb 25, 2022
@ctlong ctlong changed the title Feat: Purely a cf CLI plugin Feat: Modernize as a cf CLI plugin Feb 25, 2022
@ctlong ctlong marked this pull request as ready for review February 26, 2022 01:23
@ctlong
Copy link
Member Author

ctlong commented Feb 26, 2022

Will require a pipeline change when merged..

@ctlong ctlong marked this pull request as draft March 1, 2022 01:26
@ctlong ctlong closed this Mar 1, 2022
@ctlong ctlong deleted the feat/no-standalone-cli branch March 1, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctlong @cf-gitbot