Syslog Improvements (2) #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* do not log an empty new line when writing to syslog * allow operator to configure truncation on syslog
The go standard library implementation of log/syslog has been abandoned and is no longer maintained. In our tests with syslog logging in gorouter we noticed a significant performance penalty over file based logging. However, with file based logging we frequently observe broken logs because logrotate interferes with log reading / writing. This commit inlines the relevant file from log/syslog and refactors the implementation to be on-par with the file based logging. Co-authored-by: Alexander Lais <alexander.lais@sap.com>
1 task
ameowlia
approved these changes
Dec 16, 2024
Dariquest
pushed a commit
to sap-contributions/gorouter
that referenced
this pull request
Dec 17, 2024
* feat: make syslog logging useable * do not log an empty new line when writing to syslog * allow operator to configure truncation on syslog * fix: allow syslog-only logging * feat: replace log/syslog with internal version The go standard library implementation of log/syslog has been abandoned and is no longer maintained. In our tests with syslog logging in gorouter we noticed a significant performance penalty over file based logging. However, with file based logging we frequently observe broken logs because logrotate interferes with log reading / writing. This commit inlines the relevant file from log/syslog and refactors the implementation to be on-par with the file based logging. Co-authored-by: Alexander Lais <alexander.lais@sap.com> * fix: rename testState.newRequest -> testState.newGetRequest * test: add integration test for syslog access logs * test: check errors --------- Co-authored-by: Alexander Lais <alexander.lais@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR corrects and improves the direct-to-syslog logging of access logs for Gorouter.
The syslog implementation in Go has not been maintained by the Go authors since around 2015. While there are forks of the syslog code, all of them are also dormant. This PR inlines and significantly rewrites the syslog implementation, focusing on the following performance improvements:
Limitations:
Backward Compatibility
Breaking Change? Yes