Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove unneeded tools.go #149

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Fix: remove unneeded tools.go #149

merged 1 commit into from
Apr 7, 2023

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Mar 27, 2023

As of v2.8.2, Ginkgo "now includes a tools.go file in the root directory of the ginkgo package. This should allow modules that simply go get github.com/onsi/ginkgo/v2 to also pull in the CLI dependencies. This obviates the need for consumers of Ginkgo to have their own tools.go file and makes it simpler to ensure that the version of the ginkgo CLI being used matches the version of the library."

@ctlong ctlong requested a review from a team March 27, 2023 21:07
Copy link

@rroberts2222 rroberts2222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rroberts2222 rroberts2222 merged commit 1622ec8 into main Apr 7, 2023
@rroberts2222 rroberts2222 deleted the fix/tools branch April 7, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants