Make Envoy ALPN configurable #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows disabling ALPN configuration for environments where envoy should not advertise h2 support [cloudfoundry/routing-release#200] Authored-by: Greg Cobb <gcobb@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should not advertise h2 support
Thank you for submitting a pull request to the executor repository!
We appreciate the contribution. To help us understand the context for your pull request, please fill out this template to the best of your ability.
Please make sure to complete all of the following steps
Please provide the following information:
What is this change about?
Implement change described in cloudfoundry/diego-release#592
What problem it is trying to solve?
Envoy offering HTTP/2 via ALPN in environment where that causes problems.
What is the impact if the change is not made?
Clients other than Gorouter connecting to the Envoy proxy may incorrectly start talking HTTP/2 to LRPs that cannot serve HTTP/2.
How should this change be described in diego-release release notes?
Add manifest property to configure HTTP/2 for container proxies.
Please provide any contextual information.
Diego release issue: cloudfoundry/diego-release#592
Root issue: cloudfoundry/routing-release#200