-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-route options via CF cli #543
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7922fda
Per-route options via CF cli
Dariquest d8dba25
Update custom-per-route-options.html.md.erb
Dariquest 026a39d
Update custom-per-route-options.html.md.erb
Dariquest 31b0e73
Merge branch 'master' into patch-1
Dariquest b1f33a5
Rename least-connections
Dariquest 7b24f44
Fix indents + wording consistency (with doc set)
anita-flegg 11b90ca
Merge branch 'master' into patch-1
Dariquest ea118bc
Update custom-per-route-options.html.md.erb
Dariquest 6abfc03
Update custom-per-route-options.html.md.erb
Dariquest bbfe478
Update custom-per-route-options.html.md.erb
Dariquest 516dcdb
Update custom-per-route-options.html.md.erb
Dariquest 41954bc
Update custom-per-route-options.html.md.erb
Dariquest a595971
Update custom-per-route-options.html.md.erb
Dariquest b593ca8
Change Note to use note class
anita-flegg 32d49f1
Rename host MY-APP to MY-HOST
Dariquest e57290d
Correct the chapter vars
Dariquest 4226c08
Unification
Dariquest 9180f00
Remove repeating route check sections
Dariquest 907f00a
Chapter adjustments
Dariquest f711736
Last review round
Dariquest 985c202
Add api way to create a route with a per-route option
Dariquest 8645686
Tags correction
Dariquest c823864
word-level improvement
Dariquest a654620
add cf routes command doc
Dariquest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to leave the explicit change description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the command is not referring to
least-connections
in any way. The command is exactly the same when settinground-robin
from scratch. I think the additional information aboutleast-connection
can confuse the reader.