Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON encode values in SCIM filter string #3839

Merged
merged 1 commit into from
Jun 13, 2024
Merged

JSON encode values in SCIM filter string #3839

merged 1 commit into from
Jun 13, 2024

Conversation

philippthun
Copy link
Member

@philippthun philippthun commented Jun 12, 2024 •
edited
Loading

When building the SCIM filter string, all values (e.g. user ids, names) are now JSON encoded (*), i.e. #{Oj.dump(str)} instead of "#{str}".

Furthermore when receiving a TargetError, the 'error_info' (i.e. JSON response from UAA containing error details) is now logged.

(*) Excerpt from RFC7644:

SCIM filters MUST conform to the following ABNF [...] rules as specified below:

[...]

compValue = false / null / true / number / string; rules from JSON (RFC 7159)

[...]

In the above ABNF rules, the "compValue" (comparison value) rule is built on JSON Data Interchange format ABNF rules as specified in [RFC7159] [...]

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@philippthun philippthun marked this pull request as ready for review June 12, 2024 14:02
@philippthun
JSON encode values in SCIM filter string
9662c13 
When building the SCIM filter string, all values (e.g. user ids, names)
are now JSON encoded, i.e. #{Oj.dump(str)} instead of "#{str}".

Furthermore when receiving a TargetError, the 'error_info' (i.e. JSON
response from UAA containing error details) is now logged.
@philippthun philippthun force-pushed the json-encode-scim-filter branch from c8e1c84 to 9662c13 Compare June 12, 2024 14:56
johha
johha approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@johha johha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@philippthun philippthun merged commit 17284fc into cloudfoundry:main Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johha johha johha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippthun @johha