ISSUE-2161 Pass service binding parameters to service broker

[svkrieger]

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

• A short explanation of the proposed change:
  Pass service binding parameters, which were provided in an app manifest, to the service broker.

• An explanation of the use cases your change solves
  This PR is a suggestion for solving Service binding parameters in manifest are not passed to the service broker when cf push #2161

• Links to any other associated PRs

• I have reviewed the contributing guide

• I have viewed, signed, and submitted the Contributor License Agreement

• I have made this pull request to the main branch

• I have run all the unit tests using bundle exec rake

• I have run CF Acceptance Tests

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/177475107

The labels on this github issue will be updated when the story is started.

[JenGoldstrich]

Hey @svkrieger, this PR looks good to us, one thing @tstannard and I think you could maybe add explicit unit tests for when you pass in service binding parameters, and when you don't. Otherwise this seems reasonable to us, will ping folks from the services team on slack for them to also scan through this to double check that.

Thanks,
Jenna & Teal

[svkrieger]

@JenGoldstrich I can't really come up with a meaningful explicit test for the arbitrary parameters, without adding two contexts and duplicating some tests, as it is tested implicitly at the moment. And I don't think it would add that much confidence to be worth it. But let me know if you feel different. Or feel free to add one yourself, if you have one in mind.

[JenGoldstrich]

Merging, see further context: https://cloudfoundry.slack.com/archives/C07C04W4Q/p1616585842025800

Thanks again @svkrieger !!!

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/177501189

The labels on this github issue will be updated when the story is started.