Change api endpoint for listing service keys

[zhang-hua]

CLI should use the endpoint /v2/service_instances/:fake-guid/service_keys
to list service keys instead of using endpoint /v2/service_keys?q=service_instance_guid:fake-guid

[#87481016]

Signed-off-by: Hua Zhang zhuadl@cn.ibm.com

[cfdreddbot]

Hey zhang-hua!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/97387180.

[zhang-hua]

@shalako @maximilien this PR is to change the api endpoint to list service keys.
@simonleung8 @jberkhahn : please help us review the code and merge it. Thanks!

[simonleung8]

@zhang-hua This new endpoint only exists in CF release 206 and up, the code path should only use this endpoint with the newer releases, else it should revert back to the old endpoint.

Here is an example of CLI checking the CC API version
https://github.com/cloudfoundry/cli/blob/master/cf/commands/service/update_service.go#L149

We are happy to take another look once this change is made.
Thanks

[zhang-hua]

@simonleung8 : I have checked the API doc of CF release 205 and didn't found service key feature support. So it doesn't make sense to revert to old endpoint for service key. In addition, both of the endpoints are supported since service key features are developed. This change is just related to special use case to behave differently for SpaceAuditor and SpaceManager. Please clarify your concern. Thanks!

[simonleung8]

@zhang-hua , you are right, thanks for pointing that out.
The PR looks good, merged.