Expose api errors for service broker commands #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unless it is a specific case where there was no error but there were also no existing service brokers [#94892746]
|
Hey rmasand! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
| @@ -135,6 +135,27 @@ var _ = Describe("Service Brokers Repo", func() { | |||
| Expect(apiErr).To(HaveOccurred()) | |||
| Expect(apiErr.Error()).To(Equal("Service Broker my-broker not found")) | |||
| }) | |||
|
|
|||
| It("returns an error when listing service brokers returns an api error", func() { | |||
There was a problem hiding this comment.
This description reads odd... "returns... returns..."
jberkhahn
added a commit
that referenced
this pull request
Jun 11, 2015
Expose api errors for service broker commands
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/96805746. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API was returning a 403 for unauthorized service broker operations, but the CLI was making it seem like a 404. We're now going to expose all CC errors that occur. The previous behavior is retained only for the case where there is no CC error, but the list of service brokers is empty.
https://www.pivotaltracker.com/story/show/94892746
Thanks!
Raina and @Gerg
CF Services API