minimum viable change to enable delegated managers #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey ozzyjohnson! Thanks for submitting this pull request! All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/91778996. |
|
Wrong target. |
| usernameFilter := neturl.QueryEscape(fmt.Sprintf(`userName Eq "%s"`, username)) | ||
| path := fmt.Sprintf("%s/Users?attributes=id,userName&filter=%s", uaaEndpoint, usernameFilter) | ||
| users, apiErr := repo.updateOrFindUsersWithUAAPath([]models.UserFields{}, path) | ||
| // var myGUID string |
There was a problem hiding this comment.
Why are we leaving what seems to be debugging code as comments?
XenoPhex
pushed a commit
that referenced
this pull request
Feb 10, 2018
- added some additional tests - added additional logs for debugging [Fixes #155060885] (Github Issue #399) Signed-off-by: Anand Gaitonde <agaitonde@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the comments...
TODO: Tests.