Removed as admin.. clause from create-user since it is confusing. #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Story in CLI [#74893356]. When we create users using the CLI while logged in as the admin user, the CLI feedback for this uses the wording: Creating user as admin.... This was confusing at first glance as we though it meant that the new user was going to be an administrator rather than this meaning that we were logged in as admin. Before Fix : $ cf create-user abc def Creating user abc as admin... OK After Fix : create-user abc1 def1 Creating user abc1... OK
|
Hey SrinivasChilveri! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/89187278. |
jberkhahn
added a commit
that referenced
this pull request
May 28, 2015
Removed as admin.. clause from create-user since it is confusing.
|
This looks good, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story in CLI [#74893356].
When we create users using the CLI while logged in as the admin user, the CLI feedback for this uses the wording: Creating user as admin.... This was confusing at first glance as we though it meant that the new user was going to be an administrator rather than this meaning that we were logged in as admin.
Before Fix :
$ cf create-user abc def
Creating user abc as admin...
OK
After Fix :
create-user abc1 def1
Creating user abc1...
OK