Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC0027 CLI Support for Generic Per-Route Options [main] #3372

Merged
merged 28 commits into from
Feb 5, 2025
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3a97bc6
New command help
Dariquest Jan 21, 2025
7d13cab
Update-, create-, map-route, route, routes, app, apps
Dariquest Jan 21, 2025
35eb328
Missing imports
Dariquest Jan 21, 2025
274e81d
Generate fakes and two unit tests corrections
Dariquest Jan 22, 2025
d85deb4
Fix unit test json
Dariquest Jan 22, 2025
e4d93e3
Fix unit test json
Dariquest Jan 22, 2025
20b3ada
Fix lint errors
Dariquest Jan 23, 2025
59790ce
Remove unnecessary fakes
Dariquest Jan 23, 2025
cd68acd
Merge branch 'main' into updateRouteCommandsMain
Dariquest Jan 24, 2025
967ed16
Review changes
Dariquest Jan 27, 2025
059760a
Review changes units
Dariquest Jan 27, 2025
577a3af
Change DisplayText to DisplayWarning for flag spec err
Dariquest Jan 28, 2025
917e74b
Output an error if at least one option is specified incorrectly
Dariquest Jan 28, 2025
7be6622
Output an error if at least one option is specified incorrectly
Dariquest Jan 28, 2025
041b352
Merge branch 'main' into updateRouteCommandsMain
Dariquest Jan 29, 2025
3e1d55e
Fix helper
Dariquest Jan 29, 2025
5be9eba
Fix helper - remove a route option
Dariquest Jan 30, 2025
3faf27d
New integration test and adjustments of other tests
Dariquest Jan 30, 2025
4203b9f
Fix integration tests
Dariquest Jan 30, 2025
b575fde
Fix integration tests
Dariquest Jan 30, 2025
6f31f75
Fix integration tests
Dariquest Jan 31, 2025
1e90e4b
Merge branch 'main' into updateRouteCommandsMain
Dariquest Jan 31, 2025
db0abfa
Consistent naming: per-route options vs route specific options
Dariquest Jan 31, 2025
7e74a2c
Las integration test corrections
Dariquest Jan 31, 2025
e5d6069
Rename least-connections to least-connection
Dariquest Feb 3, 2025
146765f
Merge branch 'main' into updateRouteCommandsMain
Dariquest Feb 3, 2025
d288225
Merge branch 'main' into updateRouteCommandsMain
Dariquest Feb 3, 2025
e431d85
Merge branch 'main' into updateRouteCommandsMain
Dariquest Feb 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix helper - remove a route option
Dariquest committed Jan 30, 2025

Verified

This commit was signed with the committer’s verified signature.
coryan Carlos O'Ryan
commit 5be9eba88e7691ae29fbf2db7794b6e4995a8b50
5 changes: 2 additions & 3 deletions integration/helpers/route.go
Original file line number Diff line number Diff line change
@@ -72,11 +72,10 @@ func NewTCPRoute(space string, domain string, port int, options map[string]*stri

// Create creates a route using the 'cf create-route' command.
func (r Route) Create() {
r.Options = make(map[string]*string)
if r.Port != 0 {
Eventually(CF("create-route", r.Space, r.Domain, "--port", fmt.Sprint(r.Port), "--option", fmt.Sprint(r.Options))).Should(Exit(0))
Eventually(CF("create-route", r.Space, r.Domain, "--port", fmt.Sprint(r.Port))).Should(Exit(0))
} else {
Eventually(CF("create-route", r.Space, r.Domain, "--hostname", r.Host, "--path", r.Path, "--option", fmt.Sprint(r.Options))).Should(Exit(0))
Eventually(CF("create-route", r.Space, r.Domain, "--hostname", r.Host, "--path", r.Path)).Should(Exit(0))
}
}

Loading