Automate release version generation [v8] #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b
reviewed
Oct 28, 2024
a-b
reviewed
Oct 28, 2024
| @@ -3,7 +3,6 @@ NODES ?= 10 | |||
| PACKAGES ?= api actor command types util version integration/helpers | |||
| LC_ALL = "en_US.UTF-8" | |||
|
|
|||
| CF_BUILD_VERSION ?= $$(cat BUILD_VERSION) # TODO: version specific | |||
There was a problem hiding this comment.
question(non-blocking): do we still see some value in keeping build_data.yml up to date? As it was introduced as an eventual alternative to BUILD_VERSION.
There was a problem hiding this comment.
Good point, even that file can be removed. It was mostly used for min capi tests. Since we don't have any, will remove that as well
a-b
previously approved these changes
Oct 28, 2024
a-b
reviewed
Oct 28, 2024
Co-authored-by: AL Berez <a-b@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While releasing CLI, take the input from the user for minor/patch bump. Based on the selection, calculate the next release version. New build version need not be stored in a file going forward.