-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the --no-wait flag for cf continue-deployment
[main]
#3123
Support the --no-wait flag for cf continue-deployment
[main]
#3123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, added 2 nits formatting related, also the integration tests are failing, please have a look at them.
be92a09
to
bf7933c
Compare
This reverts commit bf7933c.
0e2606a
to
2f74021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…foundry#3123) * Support the --no-wait flag for `cf continue-deployment` * Update assertion on `cf continue-deployment` help text Co-authored-by: Nicolas Bender <nicolas.bender@sap.com>
Description of the Change
Supports the
--no-wait
flag for thecf continue-deployment
command.Why Is This PR Valuable?
It brings the
continue-deployment
command into alignment with other commands that deal with deployments (e.g.cf push
,cf restage
).How Urgent Is The Change?
Urgent, as we'd like to include this in our pending release.
Related PRs
cf continue-deployment
[v8] #3122