Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the --no-wait flag for cf continue-deployment [main] #3123

Merged

Conversation

chinigo
Copy link
Contributor

@chinigo chinigo commented Aug 19, 2024

Description of the Change

Supports the --no-wait flag for the cf continue-deployment command.

Why Is This PR Valuable?

It brings the continue-deployment command into alignment with other commands that deal with deployments (e.g. cf push, cf restage).

How Urgent Is The Change?

Urgent, as we'd like to include this in our pending release.

Related PRs

@chinigo chinigo marked this pull request as ready for review August 19, 2024 21:58
Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, added 2 nits formatting related, also the integration tests are failing, please have a look at them.

command/v7/continue_deployment_command_test.go Outdated Show resolved Hide resolved
command/v7/continue_deployment_command_test.go Outdated Show resolved Hide resolved
@chinigo chinigo force-pushed the continue-deployment-with-no-wait-main branch from be92a09 to bf7933c Compare August 20, 2024 15:39
@chinigo chinigo force-pushed the continue-deployment-with-no-wait-main branch from 0e2606a to 2f74021 Compare August 20, 2024 19:54
Copy link
Contributor

@weresch weresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weresch weresch merged commit 84a04c2 into cloudfoundry:main Aug 21, 2024
20 checks passed
nicolasbender pushed a commit to sap-contributions/cli that referenced this pull request Nov 5, 2024
…foundry#3123)

* Support the --no-wait flag for `cf continue-deployment`

* Update assertion on `cf continue-deployment` help text
Co-authored-by: Nicolas Bender <nicolas.bender@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants