Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Max in flight status tests #3113

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

weresch
Copy link
Contributor

@weresch weresch commented Aug 15, 2024

Description of the Change

  • Add copy-source tests to verify max-in-flight output
  • Add rollback tests to verify max-in-flight output
  • Add restage tests to verify max-in-flight output
  • Add restart tests to verify max-in-flight output
  • Add push tests to verify max-in-flight output

This is the main branch equivalent for #3100

@a-b
Copy link
Member

a-b commented Aug 15, 2024

Looks like a network issue. I retriggered int tests.

@weresch weresch force-pushed the max-in-flight-status-tests-main branch from f19be5a to 102b9b7 Compare August 16, 2024 14:11
* Add copy-source tests to verify max-in-flight output
* Add rollback tests to verify max-in-flight output
* Add restage tests to verify max-in-flight output
* Add restart tests to verify max-in-flight output
* Add push tests to verify max-in-flight output
@weresch weresch force-pushed the max-in-flight-status-tests-main branch from 102b9b7 to d77942a Compare August 16, 2024 16:59
@a-b
Copy link
Member

a-b commented Aug 16, 2024

re-running flaked int tests

Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Added a question to make sure that the deletion of the test is not removing coverage.

integration/v7/isolated/app_command_test.go Show resolved Hide resolved
@a-b a-b merged commit 9cc8acb into cloudfoundry:main Aug 19, 2024
18 checks passed
@weresch weresch deleted the max-in-flight-status-tests-main branch August 19, 2024 21:37
nicolasbender pushed a commit to sap-contributions/cli that referenced this pull request Nov 5, 2024
* [main] Max in flight status tests

* Add copy-source tests to verify max-in-flight output
* Add rollback tests to verify max-in-flight output
* Add restage tests to verify max-in-flight output
* Add restart tests to verify max-in-flight output
* Add push tests to verify max-in-flight output

* Delete a flakey integration test that has unit test coverage
Co-authored-by: Pavel Busko <pavel.busko@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants