Fix in clearing space fields of config data on cf space-delete

[shashidharatd]

Before Fix: If cf user deleting the targeted space but with space name as
case insenstive then space fields are not deleted from the config
htipl@cf5:/go/src/github.com/cloudfoundry/cli$ cf spaces
Getting spaces in org SriniOrg as admin...
name
No spaces found
htipl@cf5:/go/src/github.com/cloudfoundry/cli$ cf target
API endpoint: https://api.10.244.0.34.xip.io (API version: 2.13.0)
User: admin
Org: SriniOrg
Space: SriniSpace

After Fix:If cf user does same steps
space fields are deleted from the config
htipl@cf5:/go/src/github.com/cloudfoundry/cli$ ./out/cf spaces
Getting spaces in org SriniOrg as admin...
name
No spaces found
htipl@cf5:/go/src/github.com/cloudfoundry/cli$ ./out/cf target
API endpoint: https://api.10.244.0.34.xip.io (API version: 2.13.0)
User: admin
Org: SriniOrg
Space: No space targeted, use 'cf target -s SPACE'

[cfdreddbot]

Hey shashidharatd!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/83828548.

[goehmen]

@shashidharatd Can you explain this a bit more. I don't think your example show a cf delete-space command so it is hard to understand the whole issue

[SrinivasChilveri]

Hi @goehmen

The Basic issue is after deleting the space spacename(cf delete-space spacename) here the actual spacename is like SriniSpace but while deleting the space name we are giving case insenstive space name srinispace (all small letters instead of capital letter of S) cf delete-space srinispace then space is deleted properly but not the config data, so because of that if cf user does cf target still its showing

API endpoint: https://api.10.244.0.34.xip.io (API version: 2.13.0)
User: admin
Org: SriniOrg
Space: SriniSpace // but this space is not there.

As shown below the org names & spaces name are case insenstive so SriniOrg ,sriniorg are same SriniSpace srinispace also same & the creation & deletion behaves properly but during cf delete-space the config data is not cleard properly.
if you see below SriniSpace, TempSpace are there & target is SriniOrg & SriniSpace.
but deleted the sapec by cf delete-space srinispace
then if we see the spaces then only TempSpace is there but if we see the target by cf target then its showing as
API endpoint: https://api.10.244.0.34.xip.io (API version: 2.13.0)
User: admin
Org: SriniOrg
Space: SriniSpace // but this space is not there.

htipl@cf5:~/go/src/github.com/cloudfoundry/cli$ cf target

API endpoint: https://api.10.244.0.34.xip.io (API version: 2.13.0)
User: admin
Org: SriniOrg
Space: SriniSpace
htipl@cf5:~/go/src/github.com/cloudfoundry/cli$ cf orgs
Getting orgs as admin...

name
SriniOrg
htipl@cf5:~/go/src/github.com/cloudfoundry/cli$ cf spaces
Getting spaces in org SriniOrg as admin...

name
SriniSpace
TempSpace
htipl@cf5:~/go/src/github.com/cloudfoundry/cli$ cf delete-space srinispace

Really delete the space srinispace?> y
Deleting space srinispace in org SriniOrg as admin...
OK
htipl@cf5:~/go/src/github.com/cloudfoundry/cli$ cf spaces
Getting spaces in org SriniOrg as admin...

name
TempSpace
htipl@cf5:~/go/src/github.com/cloudfoundry/cli$ cf target

API endpoint: https://api.10.244.0.34.xip.io (API version: 2.13.0)
User: admin
Org: SriniOrg
Space: SriniSpace
htipl@cf5:~/go/src/github.com/cloudfoundry/cli$

[SrinivasChilveri]

Hi @goehmen Do you need any more information ?

[simonleung8]

It looks good to us. merging.
Thanks for the PR.